Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated WebRTCSidebar macro from es #10326

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Remove deprecated WebRTCSidebar macro from es #10326

merged 2 commits into from
Nov 29, 2022

Conversation

Graywolf9
Copy link
Contributor

Description

Remove deprecated WebRTCSidebar macro from es

Process: replace {{WebRTCSidebar}} macro with {{DefaultAPISidebar("WebRTC")}} for files in /web/api/webrtc_api/

Motivation

The chore of deprecated macros removal

Additional details

Related issues and pull requests

Relates to #10177

@Graywolf9 Graywolf9 added the l10n-es Issues related to Spanish content. label Nov 29, 2022
@Graywolf9 Graywolf9 requested a review from a team as a code owner November 29, 2022 18:24
@Graywolf9 Graywolf9 requested review from davbrito and removed request for a team November 29, 2022 18:24
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022 •
edited
Loading

Preview URLs

Flaws (24)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /es/docs/Web/API/WebRTC_API
Title: API de WebRTC
Flaw count: 24

  • macros:
    • /es/docs/Web/API/RTCSessionDescription does not exist but fell back to /en-US/docs/Web/API/RTCSessionDescription
    • /es/docs/Web/API/RTCIceCandidate does not exist but fell back to /en-US/docs/Web/API/RTCIceCandidate
    • /es/docs/Web/API/RTCPeerConnectionIceEvent does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnectionIceEvent
    • /es/docs/Web/API/MediaStream does not exist but fell back to /en-US/docs/Web/API/MediaStream
    • /es/docs/Web/API/RTCStatsReport does not exist but fell back to /en-US/docs/Web/API/RTCStatsReport
    • and 4 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 10 more flaws omitted

(comment last updated: 2022-11-29 18:28:42)

@Graywolf9 Graywolf9 mentioned this pull request Nov 29, 2022
Closed
wbamberg
wbamberg approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @Graywolf9 !

@Graywolf9 Graywolf9 merged commit 723a198 into mdn:main Nov 29, 2022
@Graywolf9 Graywolf9 deleted the es-remove-WebRTCSidebar-macro branch July 5, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@davbrito davbrito Awaiting requested review from davbrito davbrito is a code owner automatically assigned from mdn/yari-content-es

Assignees
No one assigned
Labels
l10n-es Issues related to Spanish content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Graywolf9 @wbamberg